-
Notifications
You must be signed in to change notification settings - Fork 500
aws.cloudtrail: improve CloudTrail user identity processing #15601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
aws.cloudtrail: improve CloudTrail user identity processing #15601
Conversation
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
🚀 Benchmarks reportTo see the full report comment with |
6b2aa19
to
6f4b104
Compare
💚 Build Succeeded
History
|
|
||
- append: | ||
field: related.user | ||
value: '{{{user.changes.name}}}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit : Given we extract this from sessionContext arn with following description,
arn
The Amazon Resource Name (ARN) of the principal that made the call. The last section of the arn contains the user or role that made the call.
Wouldn't a name like user.arn.principal
better match this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyway not a blocker to get this merged
"JohnDoe" | ||
"AROAIN5ATK5U7KEXAMPLE", | ||
"JohnDoe", | ||
"JohnRole1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems odd to me to map a role as a user.
"private-ec2-instance-role" | ||
"PRINCIPALID", | ||
"private-ec2-instance-role", | ||
"i-03cd6b2a7eb4bf3ae" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems more odd, since this is a session now.
Proposed commit message
For CloudTrail events, it has been updated how IAM users are handled.
In particular, for the user identity
IAMUser
type, theuser.name
anduser.id
arepopulated with the user fields that made the action/request.
For the user identity
AssumedRole
type, AWS SIEM rules need roles to be treated as IAMUsers in order to work fine. So the role identifies insidesessionIssuer
populateuser.*
fields. Then, the session name is being mapped asuser.changes.name
as it can be interpreted as the name the user is taking for that particular session, and it's the closest approach in ECS.References:
Checklist
changelog.yml
file.Related issues